Run all program-test in SBF mode and speed up CI #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
buffalu
commented
Feb 8, 2024
•
buffalu
commented
- Run in SBF mode to make sure actual BPF and runtime restrictions are being enforced. This should help us catch runtime errors before they make it to prod.
- Speed up CI to get fast iteration cycles
- Cleanup some compiler warnings by renaming functions to not have overlap
Speed up CI a bunch Some cleanup for compiler warnings
buffalu
changed the title
ebatsell
reviewed
Feb 8, 2024
| uses: baptiste0928/cargo-install@v3 | ||
| with: | ||
| crate: anchor-cli | ||
| version: "0.29.0" |
There was a problem hiding this comment.
this should be anchor 0.28
There was a problem hiding this comment.
CI not liking 0.28.0. unless you feel strongly about it, 0.29.0 seems fine as 0.28.0 never made it to crates.io
| @@ -797,7 +797,7 @@ | |||
| "type": "u8" | |||
| }, | |||
| { | |||
| "name": "num_addrs", | |||
| "name": "numAddrs", | |||
There was a problem hiding this comment.
this shouldn't change as long as we're still on anchor 0.28, maybe the solana program test compatibility is fixed with the new way we're loading in programs but we'd still need to bump versions and make the code compatible
added to readme |
ebatsell
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.